Open
Conversation
a82f9e6 to
431787f
Compare
Owner
|
This could certainly be useful, but it will be brutally slow (and incredibly memory hungry) for a number of use cases. It might be worth at least using sklearn's NearestNeighbor or KNeighborTransformer classes for the computation rather than computing all pairwise distances (which is fine for small data, but perilously memory expensive for large data). |
Contributor
Author
|
@lmcinnes , this sounds plausible, but I won't do it now. Feel free to close this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the threshold of 4096 for deciding the distance algorithm is a bit arbitrary and depends on machine speed, this pull request introduces another argument
force_exact_distancesas an opposite to the existingforce_approximation_algorithm.