Open
Conversation
Owner
|
This is potentially useful, although it does result in longer runtimes for umap as the lazy loading occurs at runtime. This may be a little unexpected for some users. Let me think about this and see if I can work out what the right trade-off is here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Leland,
How do you feel about doing something like this?
pynndescent is adding ~5 seconds on my m1 mac from import when not using umap yet, only importing it for types.
I used
py-spyto clarify that most of the umap import time is from, if you like I can message you the json and how to web inspect it.This helps my developer experience, and it adds some complexity.
Lazy Import Implementation:
loading