Skip to content

Expose Eigensolver's init and method arguments in UMAP class#1143

Open
duguyue100 wants to merge 5 commits intolmcinnes:masterfrom
duguyue100:master
Open

Expose Eigensolver's init and method arguments in UMAP class#1143
duguyue100 wants to merge 5 commits intolmcinnes:masterfrom
duguyue100:master

Conversation

@duguyue100
Copy link
Copy Markdown

@duguyue100 duguyue100 commented Jul 24, 2024

Changing init and method in the _spectral_layout function can sometimes make a big performance difference. However, since UMAP doesn't expose these parameters, it's almost impossible to change them without copying a local copy and changing the code. Here I exposed them in the UMAP class.

FYI

  • I didn't touch the AlignUMAP and Parametric UMAP objects. We could update them if the reviewers see this is a viable option.
  • My doc formatter slightly changed some docstring lines, hopefully this is fine.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Jul 24, 2024

Hello @duguyue100! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 735:53: E203 whitespace before ':'
Line 738:45: E203 whitespace before ':'

Comment last updated at 2024-07-25 08:16:37 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants