Use values with smaller error for tan.16 - #1512
Merged
Merged
Conversation
A few of the values here were a bit too likely to differ across APIs and hardware. - In practice I would expect most uses of tan (especially in half precision) to be on inputs between -2pi and 2pi, and values like 100.0h that are 10pi or more could easily hit a lot of intermediate rounding. - The 100pi input here is pretty far off from being representable in half (0x5ce9 is 314.25), so we're just testing another arbitrary value here that is also susceptible to rounding errors. Using the well-known 355/113 approximation of pi we can test something that's more likely to be consistent. - We didn't have a test for pi itself, which seems pretty useful. - An arbitrary number in the likely range is also a good idea, so I added cases for 2.0h.
bob80905
approved these changes
Sep 10, 2026
bob80905
approved these changes
Sep 10, 2026
kmpeng
reviewed
Sep 10, 2026
tan(2.0h) is 2 ULPs off on AMD. We could arguably bump this all the way up to 4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few of the values here were a bit too likely to differ across APIs and hardware.