[DirectX][SPIRV] Allow configuration of instanced draw parameters - #1510
[DirectX][SPIRV] Allow configuration of instanced draw parameters#1510jzakharovnv wants to merge 1 commit into
Conversation
dnovillo
left a comment
dnovillo
left a comment
There was a problem hiding this comment.
Thanks for these tests. I'm not very experienced with OTS, so I may have missed a few things in my review.
| "pipeline. Only allowed on a TraditionalRaster pipeline."); | ||
| if (DispatchParameters.InstanceCount != 1 || | ||
| DispatchParameters.FirstVertex != 0 || | ||
| DispatchParameters.FirstInstance != 0) |
There was a problem hiding this comment.
RT dispatch does not consume these fields. Could you reject nondefault InstanceCount, FirstVertex, and FirstInstance values in the RayTracing case and add a parsing test that verifies the error?
There was a problem hiding this comment.
Yes, let me add this too with the next commit
| Entry: main | ||
| DispatchParameters: | ||
| VertexCount: 3 | ||
| InstanceCount: 4 |
There was a problem hiding this comment.
FirstVertex and FirstInstance do not seem covered. Could you add a test with non-zero FirstVertex and FirstInstance? When reading back start vertex location and start instance location, SV_InstanceID should remain zero-based.
There was a problem hiding this comment.
Yeah, let me add testing for those in the following days.
3 participants
Fixes #1444 and hlsl wg issue
Testing for SV_InstanceID
Marked xfail until clang SV_InstanceID implementation and clang SV refactor land
@dnovillo @pow2clk
Assisted-by: LLM