Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #896 +/- ##
========================================
Coverage 41.48% 41.48%
========================================
Files 22 22
Lines 1509 1509
Branches 213 213
========================================
Hits 626 626
Misses 838 838
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
python main.py ...topython benchpark ..., which results in clearer usage statements.Original goal is to execute from
bin/benchparksuch that usage statements arebenchpark ...instead ofmain.py ...Adding/modifying a system (docs: Adding a System)
systems/system_name/system.pyfilesystem_namein.github/workflows/run.ymlsystems/all_hardware_descriptions/hardware_name/hardware_description.yamlwhich will appear in the docs catalogueAdding/modifying a benchmark (docs: Adding a Benchmark)
repo/benchmark_name/package.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.repo/benchmark_name/application.pyplus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.application.pyor inrepo/benchmark_name/application.pywill appear in the docs catalogueexperiments/benchmark_name/experiment.pyto define a single node and multi-node experiments.github/workflows/run.ymlAdding/modifying core functionality, CI, or documentation:
.github/workflowsand.gitlab/testsunit tests (if needed)