Open
Conversation
MrBurmark
reviewed
Jul 11, 2022
Member
|
I can't believe shfl is still broken either, its been broken as long as I can remember. Does it make sense to put the shfl workaround in camp? |
Member
Author
|
The solution turned out to be trivial, and it's on its way in so it'll be in llvm 15 most likely. That said, there are a lot of older versions around, so if anything outside RAJA wants to use it I'd have no issue moving it over there. |
Member
Author
|
Upstream patch now up for review: https://reviews.llvm.org/D129536 |
Member
Author
|
Assuming this passes, anyone willing to review/merge? As far as I know this is working, and the patch has been merged upstream. |
Member
|
@trws we need to pull the branch from the fork into our repo and make a new PR for Gitlab CI to run |
Co-authored-by: Jason Burmark <MrBurmark@users.noreply.github.com>
3b88c34 to
cc9ce6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full summary is above.
RAJA_CUDA_COMPILER_*One note, if compiling with CUDA 10.1 such that the submodule version of cub is used, we must define
-DCUB_USE_COOPERATIVE_GROUPS=1because cub mis-identifies cuda as being a very old version and uses incorrect unsynchronized shuffles without it. Newer versions of cub have this fixed, but require use of a clang version at least 14, and the version currently installed on LC (14.0.4) was built without cuda support, so test with a bit of care.