Skip to content

WIP: cleanup idea/topic views#5347

Open
goapunk wants to merge 130 commits intodevfrom
jd-2023-12-cleanup-views
Open

WIP: cleanup idea/topic views#5347
goapunk wants to merge 130 commits intodevfrom
jd-2023-12-cleanup-views

Conversation

@goapunk
Copy link

@goapunk goapunk commented Dec 4, 2023 •
edited
Loading

Proposal for a cleanup of all the views we changed to react,they don't need to be ListViews with an associated model and queryset anymore.

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk force-pushed the jd-2023-12-cleanup-views branch from c6561ed to c2f2772 Compare December 4, 2023 15:43
@goapunk goapunk changed the title cleanup idea/topic views WIP: cleanup idea/topic views Dec 5, 2023
@goapunk goapunk force-pushed the jd-2023-12-cleanup-views branch 5 times, most recently from 2396d5b to 5ecdec5 Compare December 6, 2023 17:03
goapunk
goapunk commented Dec 6, 2023
View reviewed changes
requirements/base.txt
easy-thumbnails[svg]==2.8.5
git+https://github.com/liqd/django-autoslug.git@liqd2212#egg=django-autoslug
python-dateutil==2.8.2
python-magic==0.4.27
Copy link
Author

@goapunk goapunk Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required in a4 already, so easiest to use it in mb as well

@goapunk goapunk changed the title WIP: cleanup idea/topic views cleanup idea/topic views Dec 6, 2023
@goapunk goapunk requested review from hom3mad3, m4ra and philli-m and removed request for hom3mad3, m4ra and philli-m December 6, 2023 17:07
@goapunk goapunk changed the title cleanup idea/topic views WIP: cleanup idea/topic views Dec 6, 2023
@goapunk goapunk force-pushed the jd-2023-12-cleanup-views branch from 5ecdec5 to 3e26501 Compare December 7, 2023 08:00
@goapunk
Copy link
Author

goapunk commented Jan 23, 2024

wip till we merged the map pr

philli-m and others added 11 commits March 18, 2024 11:52
@philli-m
base.html: add imports for berlin css and js and add local versions a…
3b1b3dc 
…nd image files
@philli-m
assets/js: adding js files locally to avoid development issues and up…
d4351e9 
…date linting
@philli-m
assets/berlin_css: add font awesome locally and include mention in re…
f299b8e 
…adme about local styling files
@m4ra
.github/workflows: add dev branch
424859f
@philli-m
cms/header: add BO header template and logos, a11y info to header pag…
a029042 
…es setting, rm old styling
@philli-m
footer: create new footer snippet to enable titles and replace footer…
af36d63 
… template with BO one
@philli-m
logo.png: change static path to change case so can be found in static…
f86b9cd 
… file
@m4ra
documents/views: add extra context in paragraph detail view
46396e9
@philli-m
base.html: update favicon paths to use statis tag
766ea7d
@philli-m
breadcrumb: add breadcrumb templates code to all user side project an…
81ba4e8 
…d module type detail and create templates
@philli-m
templates/*: add breadcrumbs to user settings pages and moderate pages
c91efd3
philli-m and others added 19 commits March 18, 2024 14:36
@philli-m
dashboard/module_blueprint_list_dashboard.html: add empty menu block …
3d4385c 
…to ensure menu is not rendered on blueprint modal
@philli-m
Makefile: update the html linting to remove contradictory rules
4d1a1f8
@philli-m
assets/tabs-tabnavigation: change element name and implement tab styl…
ea73ace 
…ing copied from berlin.de site fixes #5364
@philli-m
user_indicator: add the 'my account' heading to login menu and make …
ff20fe9 
…styling more specific fixes #5402
@philli-m
react/CardStats: update stat strings to include plural versions and c…
467e319 
…ontext for required strings fixes #5370 and fix tests
@philli-m
a4dashboard/nav_modules: increase modal size for module chooser to en…
690edbd 
…sure enough space for tiles
@hom3mad3
templates/meinberlin_projects/project_detail.html: hero-unit redesign…
9a23c9f 
… issues fix
@hom3mad3
assets/phase-info: remove fullwidth overwrites
876f545
@hom3mad3
assets/scss/components_user_facing/_herounit_image_with_aside.scss: f…
e025cf5 
…ix issue with margin gap on container
@hom3mad3
templates/account: redesign signup and login forms
750e669
styles_user_facing/_variables: add BO breakpoints
beafad5
assets/scss: add styling for new comment_form
1a49e53
component_user_facing/_control-bar: remove non-working media query
ab91086
@vellip
maps: implement react-leaflet and rebuild maps for it
e5a4609
@hom3mad3
meinberlin_contrib/item_detail.html: redesign moderator feedback
82a7c72
@vellip
control-bar: always apply is_archived filter
b5e47d6 
fixes #5381
@vellip
control-bar: ui/ux fixes
1d68ade 
fixes #5365
@vellip
control-bar: hide filter section when there is no filter
f4c4f54 
fixes #5397
update a4 hash
2a273f1
@goapunk goapunk force-pushed the jd-2023-12-cleanup-views branch from 3e26501 to f2c6127 Compare April 2, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@goapunk @philli-m @m4ra @hom3mad3 @vellip