Merged
Conversation
…d migration cause old one dodi worked for me
partizipation
changed the title
glanzel
requested changes
Jul 2, 2025
Contributor
glanzel
left a comment
glanzel
left a comment
There was a problem hiding this comment.
Comments App is outdated and should be removed.
The rest looks good to me
partizipation
commented
Jul 2, 2025
| class Scene(models.Model): | ||
| content_type = models.ForeignKey(ContentType, on_delete=models.CASCADE) | ||
| content_type = models.ForeignKey( | ||
| ContentType, on_delete=models.CASCADE, related_name="scenes" |
Contributor
Author
There was a problem hiding this comment.
@shn-liqd This is from one of your changes but I thought it already went to main, does it look alright to you if this is merged as part of my PR or does it suggest something went wrong in git?
Contributor
Author
There was a problem hiding this comment.
@glanzel with the more simplified API now, do we still need the scenes related name?
shn-liqd
reviewed
Jul 3, 2025
shn-liqd
reviewed
Jul 3, 2025
shn-liqd
reviewed
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unauthenticated users can now add comments and ratings using an AR endpoint. Leveraging the
django-guest-userlibrary similar to a4-roots, a guest user will be created for them, and labeled as "AR comment" when leaving comments.Uses branch-off of a4 with modified comments-async serializer to achieve comment labeling: liqd/adhocracy4#1802
ST-490