Conversation
glanzel
left a comment
glanzel
left a comment
There was a problem hiding this comment.
May be a better Solution than the API i come up with.
util/minio_client.py
Outdated
|
|
||
| try: | ||
| client = get_minio_client() | ||
| bucket_name = settings.MINIO_DATA["bucket"] |
There was a problem hiding this comment.
Why not get the bucket_name from the mesh_id as is is present in there as parts[0] anyway?
There was a problem hiding this comment.
this gives us the control to define which bucket the client can try to access
There was a problem hiding this comment.
okay but then the mesh_id then include unnecessary information. i feel it could be confusing if you have to set a bucket in the mesh id every time but it changes nothing.
Would be better if there is no bucket inside the mesh_id or instead may use a ALLOWED_BUCKETS ? and check if the bucket which is specified is allowed ?
glanzel
left a comment
glanzel
left a comment
There was a problem hiding this comment.
I am okay with that but would still suggest to changed something about buckets probably use ALLOWED_BUCKETS and check if the bucket which is specified in mesh_id is allowed
… keys from frontend
shn-liqd
force-pushed
the
so-2025-06-minio-integration
branch
from
f21473f to
a4e044a
Compare
4 participants
Tasks