feat: calculate declination variables BM-1635#125
Draft
tawera-manaena wants to merge 11 commits intomasterfrom
Draft
feat: calculate declination variables BM-1635#125tawera-manaena wants to merge 11 commits intomasterfrom
tawera-manaena wants to merge 11 commits intomasterfrom
Conversation
Changes SummaryTotal Features Changed: 0 Kart DiffKart Diff (0 features)Git DiffGit Diff (1 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This piece of work closely relates to this pull request.
Motivation
The magnetic declination panel tells map users the difference between grid north and magnetic north for this map sheet, including the rate of change over time. This is critical information for users navigating with a compass. Replicating this in QGIS ensures the panel is dynamically generated from accurate, location-specific data rather than manually authored, reducing the risk of error and the burden on cartographers.
Modifications
packages/
map/
src/
cli/
action.produce.tsRenamed the
mapSheetsvariable tosheetCodesince it only ever denotes exactly one.python.runner.tsUpdated the QGIS flatpak container to
build-38as we require the GeographicLib module.DockerfileUpdated the QGIS flatpak container to
build-38as we require the GeographicLib module.README.mdUpdated a few of the example commands to match the new Data Lake structure.
qgis/
assets/models/
igrf13.wmm&igrf13.wmm.cofAdded as they are required for the
magnetic_declinationQGIS expression.src/
qgis_export.py🚧 WORK IN PROGRESS 🚧
Extended the existing logic to calculate the variables required to generate the magnetic declination component. This file has now since ballooned and would hugely benefit from a re-structure.
To Do
The
yearvariable needs to be parameterised to support generating historic maps. Otherwise, the current year is always assumed.The
convergenceandproject_years_for_pos_half_degare not yet calculated code-side. The equations for these are somewhat unknown. Further clarity is required.Verification
I attempted to run a Map Production workflow (Argo). However, I ran into an issue.