Merged
Conversation
Owner
linw1995
commented
Aug 20, 2025
linw1995
commented
- Change return type from WorkspaceSymbolResult to Option
- Remove unused WorkspaceSymbolResult struct definition
- Align workspace symbols response with standard LSP document symbol format
…olResult struct - Change return type from WorkspaceSymbolResult to Option<DocumentSymbolResult> - Remove unused WorkspaceSymbolResult struct definition - Align workspace symbols response with standard LSP document symbol format
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the return type of the lsp_workspace_symbols function to align with standard LSP document symbol format. The change simplifies the type system by removing an unnecessary wrapper struct and using the existing DocumentSymbolResult type directly.
- Change
lsp_workspace_symbolsreturn type fromWorkspaceSymbolResulttoOption<DocumentSymbolResult> - Remove the unused
WorkspaceSymbolResultstruct definition - Update both trait definition and implementation to use the new return type
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Document the fix for lsp_workspace_symbols return type consistency in the unreleased section of the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.