Conversation
- Upgrade rmcp from 0.3.0 to 0.5.0 for latest features - Update all Cargo.lock dependencies to latest versions - Fix CallToolResult content field access pattern in integration tests - Handle optional content field with proper null checking
Add custom deserializer supporting both string and object formats. Support JSON-embedded-as-string deserialization for Claude Code MCP usage patterns. Add comprehensive test coverage for all deserialization scenarios.
- Enhanced JSON string parsing with detailed error messages - Use serde::de::IgnoredAny for better forward compatibility
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances DocumentIdentifier deserialization to support Claude Code compatibility by implementing custom deserialization logic and updating the rmcp dependency. The changes enable handling of JSON strings embedded in API calls and provide better forward compatibility.
- Implements custom deserialization visitor for DocumentIdentifier to handle both direct objects and JSON strings
- Updates rmcp dependency from 0.3.0 to 0.5.0
- Refactors integration test assertions to handle optional content fields safely
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/neovim/client.rs | Adds custom DocumentIdentifier deserializer with comprehensive test coverage |
| src/server/integration_tests.rs | Updates content field access patterns to use safe optional chaining |
| Cargo.toml | Upgrades rmcp dependency to version 0.5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #16