change: [DPS-36290] - Logs default log path tooltip show only enabled types #13307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return `${getDestinationTypeOption(destination.type)?.label}`; | ||
| }; | ||
|
|
||
| export const checkLkeEAuditLogsTypeSelectionEnabled = ( |
Contributor
There was a problem hiding this comment.
I'd change it to useIsLkeEAuditLogsTypeSelectionEnabled hook:
export const useIsLkeEAuditLogsTypeSelectionEnabled = (): boolean => {
const { data: account } = useAccount();
return !!account?.capabilities?.includes(
'Akamai Cloud Pulse Logs LKE-E Audit'
);
};
Contributor
Author
There was a problem hiding this comment.
Question for Linode team reviewer:
Should we maybe move this to useIsACLPLogsEnabled hook? Or is it better to leave it as a separate one?
kagora-akamai
force-pushed
the
feature/DPS-36290-toottip-shows-data-for-kubernetes-and-audit-logs
branch
from
ac5c7c7 to
00d7370
Compare
Collaborator
Cloud Manager UI test results🔺 2 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/databases/advanced-configuration.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts" |
||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Change text visibility of Log Path info tooltip based on account capabilities.
Changes 🔄
For user without
Akamai Cloud Pulse Logs LKE-E Auditcapability, do not show LKE sample path.Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
January 2026
Preview 📷
How to test 🧪
Verification steps
Go to Destination Create page (
/logs/delivery/destinations/create) and hover over info icon next toSample Destination Object Name. If your account hasAkamai Cloud Pulse Logs LKE-E Auditcapability you should see 2 default paths described, if it does not then you should only seeAudit Logspath described.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🔐 Removing all sensitive information from the code and PR description
📱 Providing mobile support
As an Author, before moving this PR from Draft to Open, I confirmed ✅