-
Notifications
You must be signed in to change notification settings - Fork 392
upcoming: [UIE-9395] - Edit Connection Pool Drawer #13304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
upcoming: [UIE-9395] - Edit Connection Pool Drawer #13304
Conversation
e0b0c7f to
c9100de
Compare
...rc/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseEditConnectionPoolDrawer.tsx
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseEditConnectionPoolDrawer.tsx
Show resolved
Hide resolved
...rc/features/Databases/DatabaseDetail/DatabaseNetworking/DatabaseEditConnectionPoolDrawer.tsx
Show resolved
Hide resolved
|
Looks like there's a merge conflict after the recent merge. |
smans-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my feedback was addressed and I've tested out the changes! This looks good to me, so I've approved!
Cloud Manager UI test results🎉 865 passing tests on test run #6 ↗︎
|
aaleksee-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I see that there're some failed tests in DatabaseEditConnectionPoolDrawer.test.tsx
mpolotsk-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Description 📝
Add Edit Connection Pool drawer to the Database Networking -> PgBouncer Connection Pools section
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-22.at.1.10.38.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅