Skip to content

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Jan 20, 2026

Description 📝

Now that we're receiving real API data, it has been confirmed that we can use API filters for sorting, pagination + the ability to filter by company. This allow us to only fetch what we need, and improve performance for large accounts by relying on API methods.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Fetch paginated on demand records (not ALL records) and clean up obsolete ALL query
  • Update sorting, pagination and filtering to use X-Filters and params
  • Update invalidation
  • Fix tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

How to test 🧪

Verification steps

  • Navigate to a user's delegation: /iam/users/<user>/delegations and interact with table and search

    • ✅ confirm pagination and sorting is working and params being appended to the URL
    • ✅ confirm X-Filters and search is working properly
  • Navigate to /iam/delegations and update delegation, navigate back to the user added to the delegation

    • ✅ confirm invalidation worked, endpoint is refetched and UI updated accordingly
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai changed the title [UIE-9298] upcoming: [UIE-9298] IAM Parent/Child - Enable server side filters on User Delegations Jan 20, 2026
@abailly-akamai abailly-akamai marked this pull request as ready for review January 21, 2026 08:45
@abailly-akamai abailly-akamai requested a review from a team as a code owner January 21, 2026 08:46
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up 🧹

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Jan 21, 2026
@abailly-akamai abailly-akamai changed the base branch from develop to release-v1.158.0 January 22, 2026 12:48
@abailly-akamai abailly-akamai changed the base branch from release-v1.158.0 to develop January 22, 2026 12:48
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing864 Passing11 Skipped39m 35s

Details

Failing Tests
SpecTest
clone-linode.spec.tsCloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

@abailly-akamai abailly-akamai merged commit a39186a into linode:develop Jan 26, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI IAM (Identity & Access Management)

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

5 participants