-
Notifications
You must be signed in to change notification settings - Fork 392
upcoming: [UIE-9816] - Add Marketplace filters to the Products landing page #13292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| if (value && value !== textFieldValue) { | ||
| if (value !== textFieldValue) { | ||
| setTextFieldValue(value); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change ensures that the internal state correctly synchronizes with the value prop even when it is an empty string. Previously, the condition value && value !== textFieldValue prevented updates when value was "", so clearing the search field would not update the internal state or reflect in the UI. By changing the condition to value !== textFieldValue, the field now correctly resets, and the UI and internal state stay in sync when the search field is cleared.
We can test this by resetting the filters from the Filters empty state to ensure the field clears/resets correctly in the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is used throughout the app, have you tested other areas to confirm there have been no regressions/behavior changes? I spot checked a few places and didn't notice any.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did check and didn't notice any issues either
dwiley-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verification steps ✅
Code review ✅
| if (value && value !== textFieldValue) { | ||
| if (value !== textFieldValue) { | ||
| setTextFieldValue(value); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component is used throughout the app, have you tested other areas to confirm there have been no regressions/behavior changes? I spot checked a few places and didn't notice any.
|
As discussed, When filtering also let's make use of waypoint and handle empty state by making api call in batches if no products are found. |
| !isLoading && | ||
| (totalCategories === 0 || | ||
| (hasFiltersApplied && | ||
| allCategoriesLoaded && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change to use allCategoriesLoaded here.
packages/manager/src/features/Marketplace/MarketplaceLanding/CategorySection.tsx
Show resolved
Hide resolved
This logic is already handled in the current implementation of MarketplaceLanding.tsx at L199-L222 |
Cloud Manager UI test results🔺 1 failing test on test run #12 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
Description 📝
Add Marketplace filters to the Products landing page.
Below is the X-Filter header structure that will be sent to the API based on the filters selected by the user in the UI:
Details
1. Search by product name / description only When the user enters text in the search input without selecting category or type:When only category and type are selected from the dropdowns:
When the user enters search text and also selects category and type:
When the search input matches partner names, matching partner IDs are resolved and included in the +or condition along with product name/description:
When the search input matches type names and only category is selected, matching type IDs are included in the +or condition:
Note
The APIs are not available yet.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
N/A
Preview 📷
Filters:

Empty States:
When filters are applied:

When no categories with products are available:

How to test 🧪
Prerequisites
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅