-
Notifications
You must be signed in to change notification settings - Fork 391
fix: [UIE-9841] - Hide dual stack option if no IPv6 prefixes available in create VPC flow #13245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [UIE-9841] - Hide dual stack option if no IPv6 prefixes available in create VPC flow #13245
Conversation
…e in create VPC flow
0e2b1d4 to
4b26ac6
Compare
dwiley-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ticket says, "If the available VPC IPv6 prefix lengths for a DC is empty, then dual-stack should not be shown," but this PR makes it not shown if there are zero or one prefix lengths. What's correct here? With the current logic it seems like Dual Stack won't be available for any region at this moment.
packages/manager/src/features/VPCs/VPCCreate/FormComponents/VPCTopSectionContent.tsx
Outdated
Show resolved
Hide resolved
Initially I thought we have to hide this even if only /52 prefix is available as per this condition. But I see that prefix will be defaulted to /52 even if prefixes are not shown when its length is 1. So updated the condition to show dual-stack option if there are any prefixes available. |
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
Description 📝
As part of this PR, if the available VPC IPv6 prefix length for a DC is 0, then dual-stack option should not be shown under IP stack in create VPC flow.
Changes 🔄
availableRegionIPv6PrefixLengths > 0, only then showIPv4 + IPv6 (Dual Stack)option in create VPC screen.VPC IPv6 Large Prefixestag.Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
NA
Preview 📷
How to test 🧪
Prerequisites
new-dc-testing-alphatag in prod account.Reproduction steps
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅