Refactor schema: collapse category-specific slots into canonical slot…#6
Merged
diatomsRcool merged 1 commit intomainfrom Feb 23, 2026
Merged
Refactor schema: collapse category-specific slots into canonical slot…#6diatomsRcool merged 1 commit intomainfrom
diatomsRcool merged 1 commit intomainfrom
Conversation
…s with modifiers Apply category collapse design principle: when multiple variables represent the same quantitative construct differing only by a categorical qualifier, use ONE canonical slot with modifier axes instead of separate slots. Changes: - Add SpO2ThresholdEnum and CO2ThresholdEnum modifier axes - Add spo2_threshold and co2_threshold modifier slots - Replace body position slots (supine_duration_min, etc.) with body_position_duration_min + body_position modifier - Replace apnea type slots (central_apnea_index, etc.) with apnea_index + apnea_type modifier - Replace SpO2 threshold slots (time_below_90_pct_min, etc.) with time_below_spo2_threshold_min + spo2_threshold modifier - Replace CO2 threshold slots (time_co2_above_50_pct, etc.) with time_above_co2_threshold_percent + co2_threshold modifier - Update BodyPositionMetric, OxygenSaturationMetric, CapnographyMetric classes - Document design principle in schema description 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s with modifiers
Apply category collapse design principle: when multiple variables represent the same quantitative construct differing only by a categorical qualifier, use ONE canonical slot with modifier axes instead of separate slots.
Changes:
🤖 Generated with Claude Code