2nd iteration Fixes

[PavelLinearB]

✨ PR Description

Purpose: Implements a basic client-server chat application using TCP sockets and threading in Python.

Main changes:

• Created client module with socket connection and message handling functionality
• Developed server module with multi-client support using threaded connections
• Implemented data streaming with chunked message handling for larger messages

This description was generated by LinearB AI and Added by gitStream

[gitstream-cm]

✨ PR Review Suggestion

Bug - src/server/server.py (Line 70)

Details:

Problem: Thread creation has incorrect args format - should be tuple
Fix: Add comma to make single argument a tuple
Why: Without comma, args expects a sequence but gets a single value, causing TypeError

-    newConnectionsThread = threading.Thread(target = newConnections, args = (sock))
+    newConnectionsThread = threading.Thread(target = newConnections, args = (sock,))

Security - src/client/client.py (Line 18)

Details:

Problem: Bare except clause catches all exceptions including KeyboardInterrupt
Fix: Specify socket.error exception type
Why: Catching specific exceptions improves error handling and allows clean program termination

-        except:
+        except socket.error:

Security - src/server/server.py (Line 34)

Details:

Problem: Bare except clause catches all exceptions including KeyboardInterrupt
Fix: Specify socket.error exception type
Why: Catching specific exceptions improves error handling and allows clean program termination

-            except:
+            except socket.error:

This review was generated by LinearB AI and Added by gitStream