You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We discussed a LimboParallelState approach on Discord that would implement #129
Here is a proof of concept, looking for suggestions and feedback.
The repetition of the loop code over children feels somewhat inelegant.
I'm not sure about the event consuming behaviour, right now if one child state consumes then the ParallelState itself will not get a dispatch, which seemed sensible.
There's no solution to the get_leaf_node problem yet, we just return the parallel state itself. (We talked about deprecating that and replacing with a get_leaf_nodes func.)
Nice implementation! I think it's good as it is, just needs some tests. Can you add tests for this class? They can be added to the hsm test suite, or in a separate file.
We’ll add an icon in a follow-up. The get_leaf_states() function can also be introduced later, it doesn’t need to be included here.
I'm not sure about the event consuming behaviour, right now if one child state consumes then the ParallelState itself will not get a dispatch, which seemed sensible.
Hey @adammitchelldev
Do you have any plans to continue working on this PR? If not, I’ll mark it as salvageable and may pick it up where you left off.
No, not right now, feel free to mark it as salvageable.
limbonaut
added
the
salvageable
This PR can be picked up and continued by someone else from where the original author left off.
label
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvageableThis PR can be picked up and continued by someone else from where the original author left off.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discussed a
LimboParallelStateapproach on Discord that would implement #129Here is a proof of concept, looking for suggestions and feedback.