Skip to content

cli(shell-sync): add BATS tests for metadata change#4842

Merged
jandubois merged 1 commit intolima-vm:masterfrom
unsuman:add/shell-sync-metadata-test
Apr 19, 2026
Merged

cli(shell-sync): add BATS tests for metadata change#4842
jandubois merged 1 commit intolima-vm:masterfrom
unsuman:add/shell-sync-metadata-test

Conversation

@unsuman
Copy link
Copy Markdown
Member

@unsuman unsuman commented Apr 14, 2026

Fixes #4722

@unsuman unsuman force-pushed the add/shell-sync-metadata-test branch 2 times, most recently from 6eb15d4 to e92c6ca Compare April 16, 2026 16:27
@unsuman unsuman marked this pull request as ready for review April 16, 2026 16:56
jandubois
jandubois previously approved these changes Apr 18, 2026
Copy link
Copy Markdown
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Two tests however look useless to me, so I would remove before merging.

Comment thread hack/bats/tests/shell-sync.bats Outdated
Comment thread hack/bats/tests/shell-sync.bats Outdated
Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>
Copy link
Copy Markdown
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois added this to the v2.1.2 milestone Apr 19, 2026
@jandubois jandubois merged commit 7ae3e4d into lima-vm:master Apr 19, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[limactl shell --sync] Add BATS test for metadata change

2 participants