Ensure only RAW images in cache(imgconv/raw) while keeping the original image#4637
Ensure only RAW images in cache(imgconv/raw) while keeping the original image#4637unsuman wants to merge 1 commit intolima-vm:masterfrom
imgconv/raw) while keeping the original image#4637Conversation
530dd47 to
4c84d9a
Compare
|
Are RAW images not supported on Windows? |
https://learn.microsoft.com/en-us/windows/win32/fileio/sparse-file-operations says:
Maybe it is not implemented in qemu-img.exe ? |
Yes seems so, as you pointed out Is a |
Can't predict the format from the extension |
|
https://github.com/lima-vm/lima/actions/runs/22440179260/job/64980256758?pr=4637
Does |
Gemini tells me:
|
b3d02da to
f0bfc72
Compare
f0bfc72 to
07cac94
Compare
|
Current flow: Only left with adding tests to Also need to update |
imgconv/raw) while keeping the original image
a27e53b to
e03a4c2
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Move 2 lima reviews (shell-sync functionality review, PR lima-vm#4637) and their HTML versions into the per-repo reviews branch. Includes a placeholder index.html adapted from the old multi-repo index. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Add header table to shell-sync review (old format). Add PR title to Signed-off-by: Jan Dubois <jan.dubois@suse.com> lima-vm#4637. Regenerate index.html with generate-index tool.
Add header table to shell-sync review (old format). Add PR title to Signed-off-by: Jan Dubois <jan.dubois@suse.com> lima-vm#4637. Regenerate index.html with generate-index tool.
|
I improved my review agent to let subagents run more multiple passes as long as they keep finding significant additional issues. More comprehensive report: Deep Review: 20260327-223819-pr-4637 |
Signed-off-by: Ansuman Sahoo <anshumansahoo500@gmail.com>
e03a4c2 to
5a664e9
Compare
Now when a fresh image is downloaded and if it's a non-ISO image, and the image type not supported by the driver it is then converted to RAW in the cache(
imgconv/raw) and araw.digestfile is created. It also works for existing images in the cache that are not supported by the driverFixes #4056