Skip to content

Conversation

@Chris53897
Copy link
Contributor

#298

Maybe the only problem is this change.
https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-renamed-sqlite-platform-classes

TODO: I know there must be a bc layer for dbal < 4

Co-authored-by: Alexis Lefebvre <alexislefebvre@gmail.com>
@Chris53897
Copy link
Contributor Author

Solving #300 would help development.

@alexislefebvre
Copy link
Collaborator

alexislefebvre commented Apr 14, 2024

On the 3.x branch, with doctrine/dbal 4, this line is not working:

$databaseTool = $this->items[$registry->getName()][$driverName] ?? $this->items[$registry->getName()]['default'];

$this->items[$registry->getName()][$driverName] is evaluated as false, null or whatever and it switch to the statement after ??.

Update: you found the issue: DatabaseToolCollection registers an item with key Doctrine\DBAL\Platforms\SqlitePlatform then later the key Doctrine\DBAL\Platforms\SQLitePlatform is searched.

@alexislefebvre
Copy link
Collaborator

Please check this:

Feel free to backport it to the 2.x branch.

@alexislefebvre
Copy link
Collaborator

alexislefebvre commented May 4, 2024

Tests were OK on local environment but not on CI, because the versions of databases used on GitHub Actions were outdated: bf29b7d

Chris53897 and others added 2 commits January 15, 2026 14:16
Co-authored-by: Alexis Lefebvre <alexislefebvre+github@gmail.com>
Co-authored-by: Alexis Lefebvre <alexislefebvre+github@gmail.com>
@alexislefebvre
Copy link
Collaborator

alexislefebvre commented Jan 15, 2026

Can you use the 3.x branch of this bundle instead of 2.x? It should already support DBAL 4.

Are your projects locked to PHP ≤ 8.1?

@Chris53897 Chris53897 closed this Jan 15, 2026
@Chris53897 Chris53897 changed the title feat: add support for dbal 4 feat: add support for dbal 4 - for branch 2.x Jan 15, 2026
@Chris53897
Copy link
Contributor Author

thanks for this info.
i just use it in this bundle https://github.com/Dukecity/CommandSchedulerBundle

So i am fine with version 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants