fix(api): clean up bad JSON noise and fix progress bar going backwards#165
Open
iammojogo-sudo wants to merge 12 commits into
Open
fix(api): clean up bad JSON noise and fix progress bar going backwards#165iammojogo-sudo wants to merge 12 commits into
iammojogo-sudo wants to merge 12 commits into
Conversation
Added links to Modly and Lightning Pixel on X for updates.
Change error message format for JSON decoding failure.
lightningpixel
approved these changes
Jun 5, 2026
Owner
|
You’ll need to pull the dev branch and resolve the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small backend fixes.
First, when an extension's generator.py prints anything to stdout — debug
lines, tqdm bars, torch loading messages — it was showing up in the logs
as "[model] bad JSON: " on every single one. The lines weren't
malformed, they were just plain text that isn't part of the JSON protocol.
They now get forwarded to stderr as normal extension output instead.
Second, the progress bar could visibly snap backwards during generation.
The model loading phase slowly walks progress up to around 7%, but then
the extension starts its own generation and reports 0% first, resetting it.
Added a simple guard so progress can only move forward, never back.