Draft
Conversation
Add a resolveUseropName() method to centralize userop name resolution across three categories: - SLEIGH-defined userops (indices 0 to ~100) - Synthetic ops (DECLARE_*, ADDRESS_OF at 0x100000+) - Decompiler built-ins (stringdata, volatile_read/write, memcpy, strncpy, wcsncpy at 0x10000000+) This enables proper handling of CALLOTHER operations that use decompiler-injected built-in intrinsics.
CALLOTHER is a fallback pcode op for various intrinsics in high p-code, ranging from architecture specfic intrinsics to inserted decompiler intrinsics (like memcpy, strcpy, etc.). Unfortunately, Ghidra's decompiler has a limitation on all arch specific intrinsics, only allowing the Java API to access the name 'stringdata', so we need a fallback intrinsic named '__patchestry_missing_<name>', where '<name>' is the unrecognized intrinsic name.
kumarak
reviewed
Jan 29, 2026
| public static final int ADDRESS_OF = MIN_CALLOTHER + 3; | ||
|
|
||
| // Ghidra decompiler built-in userop indices (from userop.cc) | ||
| public static final int BUILTIN_STRINGDATA = 0x10000000; |
Collaborator
There was a problem hiding this comment.
Is this list sufficient for user operations?
Collaborator
|
@kyle-elliott-tob can you add unit test for CALLOTHER with calls to one of the userop or unknown intrinsic? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked as draft as this needs to be reviewed for implications and side affects before being finalized.