Skip to content

EXSC-281 Deploy IntentsEscrowFacet#1752

Draft
mirooon wants to merge 4 commits intomainfrom
deploy-intents-escrow
Draft

EXSC-281 Deploy IntentsEscrowFacet#1752
mirooon wants to merge 4 commits intomainfrom
deploy-intents-escrow

Conversation

@mirooon
Copy link
Copy Markdown
Contributor

@mirooon mirooon commented Apr 29, 2026

Which Linear task belongs to this PR?

https://linear.app/lifi-linear/issue/EXSC-281/deploy-lifiintentescrowfacet-v111

Why did I implement it this way?

Checklist before requesting a review

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

Warning

Rate limit exceeded

@mirooon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 45 minutes and 59 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 862e053c-75b2-4799-a240-3343619bbeac

📥 Commits

Reviewing files that changed from the base of the PR and between 2085841 and 6576d51.

📒 Files selected for processing (3)
  • deployments/arbitrum.diamond.json
  • deployments/base.diamond.json
  • deployments/mainnet.diamond.json

Walkthrough

Replaces the LiFiIntentEscrowFacet contract address in multiple deployment JSON manifests (arbitrum, base, jovay, mainnet, megaeth, optimismsepolia, pharos, arbitrumsepolia) with new hex addresses; no other keys changed.

Changes

Cohort / File(s) Summary
Deployment Configuration Updates
deployments/arbitrum.json, deployments/base.json, deployments/jovay.json, deployments/mainnet.json, deployments/megaeth.json, deployments/optimismsepolia.json, deployments/pharos.json, deployments/arbitrumsepolia.json
Updated the LiFiIntentEscrowFacet address in each listed deployment JSON to a new on-chain address (one-line replacement per file).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes the Linear task reference and completed checklist items, but lacks explanation of the implementation approach and leaves critical reviewer security checklists incomplete. Add 'Why did I implement it this way?' section explaining the deployment rationale, and ensure reviewer checklist items are addressed before requesting reviews.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: deploying the IntentsEscrowFacet contract across multiple deployment configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deploy-intents-escrow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 45 minutes and 59 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@lifi-action-bot lifi-action-bot marked this pull request as draft April 29, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants