Add checking availability Execute ember-cli command#41
Open
kaermorchen wants to merge 1 commit intolifeart:masterfrom
Open
Add checking availability Execute ember-cli command#41kaermorchen wants to merge 1 commit intolifeart:masterfrom
Execute ember-cli command#41kaermorchen wants to merge 1 commit intolifeart:masterfrom
Conversation
lifeart
requested changes
Sep 4, 2022
|
|
||
| export async function packageAvailable(packageName: string): Promise<boolean> { | ||
| const files = await workspace.findFiles( | ||
| `**/node_modules/${packageName}/package.json`, |
Owner
There was a problem hiding this comment.
It may be incorrect path in case of monorepos, pnpm & such.
Likely, we need to get information about available ember addons from project (from uELS)
https://github.com/lifeart/ember-language-server/blob/component-context-info-origin/src/project.ts#L40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks that the
ember-fast-clipackage is installed or not and shows the commandEmber: Execute ember-cli commandor doesn't.