Track uncommitted input text so an IME (CJK input) can query it back#15251
Open
cammeresi wants to merge 1 commit intolibsdl-org:SDL2from
Open
Track uncommitted input text so an IME (CJK input) can query it back#15251cammeresi wants to merge 1 commit intolibsdl-org:SDL2from
cammeresi wants to merge 1 commit intolibsdl-org:SDL2from
Conversation
In CJK input, keystrokes are rendered into text provisionally and may not be in the final form that will be committed to the text input widget. For example, in Korean input, a syllable is typed in using Hangeul, but the user may then decide to replace it with a Hanja character. In order for such translation to happen, the IME must be able to query back the current uncommitted text.
Collaborator
|
This generally looks good. Have you tested this with Chinese and Japanese IME composition? |
Author
No, sorry, I do not speak those languages although I think the mechanisms involved are similar. |
Collaborator
|
They're different enough that I'd like a native speaker to test your changes before accepting them. |
Author
|
I understand. Is that testing something that you will take care of? I'm afraid that I don't know any native speakers of Chinese or Japanese. If accepted, I can see about porting to SDL3 at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CJK input, keystrokes are rendered into text provisionally and may not be in the final form that will be committed to the text input widget. For example, in Korean input, a syllable is typed in using Hangeul, but the user may then decide to replace it with a Hanja character. In order for such translation to happen, the IME must be able to query back the current uncommitted text.
Existing Issue(s)
Related: skyjake/lagrange#758