feat: Added coroutine worker for importing watch history by SE-Bilal-Ahmad · Pull Request #7973 · libre-tube/LibreTube

SE-Bilal-Ahmad · 2025-11-29T20:04:22Z

1- Previously a coroutine was executed which imported watch history from youtube but there was no way to know the status of the import history i have a added a coroutine worker whose job is to import the watch history with a foreground notification.

2- I have also added dagger hilt in order to inject dependencies. I could have used other approaches but that wouldnt have been a clean solution

3- For now only watch history is being imported through coroutine worker. The reason is that we are inserting watch item one by one but for subscriptions one complete list is inserted which makes it nearly impossible to know the status of those imports however i will still look for a way to achieve that and for playlists too

Bug #7907

SE-Bilal-Ahmad · 2025-11-29T20:18:33Z

If someone wants i can add an ongoing notification for subscription and playlist imports however that will not be able to tell how much content to import has been left

Bnyro

I generally think that the idea of putting the import work into a dedicated worker goes into the right direction, thanks for proposing.

However, we decided to not add Dagger/Hilt as a dependency, so please refactor your PR to work without it.

Apart from that I left some comments, please have a look at them. Without willing to attack you personally, this code looks a bit AI-generated .

We don't accept contributions that add much additional code that was AI-generated here. So please clarify that this is not the case or rewrite the AI-generated parts as we don't have any permission to license code that was stolen from other projects as GPL3.

SE-Bilal-Ahmad · 2025-12-12T14:47:39Z

@Bnyro do i need to rewrite the other code as well by that i meant the pausing handler since thats not AI generated the only Ai generated one is the notification part that too is in much smaller portion not all of it was Ai generated so please clarify

Bnyro · 2025-12-12T14:52:14Z

Only the AI generated code.

SE-Bilal-Ahmad · 2025-12-12T14:53:21Z

okay i will be rewriting it

ULTRA-LEGENDS · 2026-01-28T19:30:22Z

@Bnyro could you please take a look at this pull request and see whether it’s ready to be merged into the app or not

Bnyro · 2026-02-19T20:32:38Z

-    private const val YOUTUBE_IMG_URL = "https://img.youtube.com"
+    private val IMPORT_THUMBNAIL_QUALITY = "mqdefault"
+    private val VIDEO_ID_LENGTH = 11
+    private val YOUTUBE_IMG_URL = "https://img.youtube.com"


Why remove const here?

Bnyro · 2026-02-19T20:34:33Z

        classpath(libs.kotlin.serialization)
        classpath(libs.androidx.navigation.safeargs)
-
+        classpath("com.google.dagger:hilt-android-gradle-plugin:2.41")


remove this please, we don't want to use dagger hilt

Bnyro · 2026-02-19T20:34:56Z

We already have an ic_pause.

Bnyro · 2026-02-19T20:35:14Z

We already have an ic_play.

Bnyro · 2026-02-19T20:38:01Z

+        val parsedId: UUID? = try {
+            UUID.fromString(id)
+        } catch (e: Exception) {
+            null
+        }


Suggested change

val parsedId: UUID? = try {

UUID.fromString(id)

} catch (e: Exception) {

null

}

val parsedId runCatching {

UUID.fromString(id)

}.getOrNull()

Bnyro · 2026-02-19T20:38:49Z

+    private val IMPORT_THUMBNAIL_QUALITY = "mqdefault"
+    private val VIDEO_ID_LENGTH = 11
+    private val YOUTUBE_IMG_URL = "https://img.youtube.com"


Please make all these values const and move them to the companion object.

Bnyro · 2026-02-19T20:45:06Z

+            }
+        }?.flatten().orEmpty()
+
+        registerReceiver()


Why register the receiver again here? It's already registered, right?

Bnyro · 2026-02-19T20:45:33Z

+        val importFormatString =
+            inputData.getString(WorkersData.IMPORT_FORMAT) ?: ImportFormat.YOUTUBEJSON.toString()
+        val importFormat = enumValueOf<ImportFormat>(importFormatString)
+        val videos = fileUrisString?.map { a ->


Suggested change

val videos = fileUrisString?.map { a ->

val videos = fileUrisString?.flatMap { a ->

and remove flatten at the end.

Bnyro · 2026-02-19T20:45:53Z

+            inputData.getString(WorkersData.IMPORT_FORMAT) ?: ImportFormat.YOUTUBEJSON.toString()
+        val importFormat = enumValueOf<ImportFormat>(importFormatString)
+        val videos = fileUrisString?.map { a ->
+            val fileUrisDeserialized = Uri.parse(a)


Suggested change

val fileUrisDeserialized = Uri.parse(a)

val fileUri = a.toUri()

Bnyro · 2026-02-19T20:46:10Z

+        val importFormatString =
+            inputData.getString(WorkersData.IMPORT_FORMAT) ?: ImportFormat.YOUTUBEJSON.toString()
+        val importFormat = enumValueOf<ImportFormat>(importFormatString)
+        val videos = fileUrisString?.map { a ->


Please use a more descriptive name instead of a.

Bnyro · 2026-02-19T20:47:28Z

remove: unused

Bnyro · 2026-02-19T20:48:54Z

+        setForeground(getForegroundInfo())
+        val pausingHandle = ImportHandler()
+        val importType = inputData.getString(WorkersData.IMPORT_TYPE)
+            ?: ImportType.IMPORT_WATCH_HISTORY.toString()


If no import type is provided, we should probably throw an error instead of just assuming that it's IMPORT_WATCH_HISTORY.

Bnyro · 2026-02-19T20:49:41Z

+    }
+
+
+    private suspend fun ImportWatchHistory(): Unit {


Suggested change

private suspend fun ImportWatchHistory(): Unit {

private suspend fun importWatchHistory(): Unit {

method names should be lowercase

Bnyro · 2026-02-19T20:50:53Z

+        }
+    }
+
+    private fun notifyNotification(notification: Notification) {


Suggested change

private fun notifyNotification(notification: Notification) {

private fun updateNotification(notification: Notification) {

Bnyro · 2026-02-19T20:51:22Z

+    }
+
+    companion object {
+        fun importWatchHistory(context: Context,uris: List<Uri>, importFormat: ImportFormat) {


Suggested change

fun importWatchHistory(context: Context,uris: List<Uri>, importFormat: ImportFormat) {

fun startImportWatchHistoryWorker(context: Context,uris: List<Uri>, importFormat: ImportFormat) {

Bnyro · 2026-02-19T20:57:12Z

+    private suspend fun checkIfPausedOrCancelled(
+        currentState: Int,
+        finalState: Int,
+        dispatch: suspend (Boolean) -> Unit
+    ) {
+        val importHandler = ImportHandler.current()
+        val now = System.currentTimeMillis()
+        if (importHandler.isPaused) {
+            dispatch(false)
+            notifyNotification(notificationFactory.updateState(currentState, finalState, ImportState.PAUSED))
+            importHandler.awaitResumed()
+        } else if (!importHandler.isPaused) {
+            dispatch(true)
+            if (now - lastUpdateTime >= updateInterval) {
+                notifyNotification(notificationFactory.updateState(currentState, finalState, ImportState.RUNNING))
+                lastUpdateTime = now
+            }
+        }
+    }


I don't really understand what this method is doing, in any case its name is not very descriptive.

As I understand it, the method is supposed to only execute the work from dispatch if ImportHandler#paused is false. However, in this case, why don't you just do

Suggested change

private suspend fun checkIfPausedOrCancelled(

currentState: Int,

finalState: Int,

dispatch: suspend (Boolean) -> Unit

) {

val importHandler = ImportHandler.current()

val now = System.currentTimeMillis()

if (importHandler.isPaused) {

dispatch(false)

notifyNotification(notificationFactory.updateState(currentState, finalState, ImportState.PAUSED))

importHandler.awaitResumed()

} else if (!importHandler.isPaused) {

dispatch(true)

if (now - lastUpdateTime >= updateInterval) {

notifyNotification(notificationFactory.updateState(currentState, finalState, ImportState.RUNNING))

lastUpdateTime = now

}

}

}

private suspend fun runActionAndUpdateNotificationIfNotPaused(

currentState: Int,

finalState: Int,

action: suspend () -> Unit

) {

val importHandler = ImportHandler.current()

val now = System.currentTimeMillis()

if (importHandler.isPaused) {

notifyNotification(notificationFactory.updateState(currentState, finalState, ImportState.PAUSED))

importHandler.awaitResumed()

} else if (!importHandler.isPaused) {

action()

if (now - lastUpdateTime >= updateInterval) {

notifyNotification(notificationFactory.updateState(currentState, finalState, ImportState.RUNNING))

lastUpdateTime = now

}

}

}

Bnyro · 2026-02-19T20:57:48Z

+        if (videos.isEmpty()) {
+            applicationContext.toastFromMainDispatcher(R.string.emptyList)


Please do this check before you execute the while loop for readability.

Bnyro · 2026-02-19T20:58:06Z

+
+
+    var lastUpdateTime = 0L
+    val updateInterval = 500L


Please make update interval a constant in the companion object.

Bnyro · 2026-02-19T21:01:21Z

    private var importFormat: ImportFormat = ImportFormat.NEWPIPE

+
+    override val titleResourceId: Int = R.string.backup_restore


Please undo this change, perhaps this was by accident?

SE-Bilal-Ahmad and others added 11 commits November 22, 2025 19:57

Added workmanager for imports

fea02f2

Merge branch 'libre-tube:master' into master

9eff765

Some more changes

1b6945a

Added dagger hilt

eb744de

Added notification factory

221122f

Added notification still needs refactoring

ef035f5

Added notification

f7bfa10

Changes related to notification

7156654

Added checks for multiple importing of history

f7ac2ec

Merge branch 'libre-tube:master' into master

8923479

Merge remote-tracking branch 'fork/master'

d6c4968

SE-Bilal-Ahmad mentioned this pull request Nov 30, 2025

Add progress indicator for import actions #7907

Open

3 tasks

Bnyro requested changes Dec 7, 2025

View reviewed changes

SE-Bilal-Ahmad and others added 8 commits December 13, 2025 12:31

Dagger hilt removed, NotificationCompactChannel used

0962a53

removed comment

b905f4c

Percentage completed now in string.xml

2ac2a37

States now renamed

50e2bbd

Change reverted

e408f9f

Channel name noew in string.xml

5d422e1

file removed

2a5024c

Merge branch 'master' into master

7a28944

Merge branch 'master' into master

6f4a961

Bnyro reviewed Feb 19, 2026

View reviewed changes

Comment thread app/src/main/res/drawable/ic_action_pause.xml

Copy link
Copy Markdown

Member

Bnyro Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have an ic_pause.

Bnyro reviewed Feb 19, 2026

View reviewed changes

Comment thread app/src/main/res/drawable/ic_action_resume.xml

Copy link
Copy Markdown

Member

Bnyro Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have an ic_play.

Bnyro reviewed Feb 19, 2026

View reviewed changes

Comment thread app/src/main/java/com/github/libretube/db/obj/StoredItemState.kt

Copy link
Copy Markdown

Member

Bnyro Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove: unused

Bnyro reviewed Feb 19, 2026

View reviewed changes

	val videos = fileUrisString?.map { a ->
	val videos = fileUrisString?.flatMap { a ->

	val fileUrisDeserialized = Uri.parse(a)
	val fileUri = a.toUri()

	private suspend fun ImportWatchHistory(): Unit {
	private suspend fun importWatchHistory(): Unit {

	private fun notifyNotification(notification: Notification) {
	private fun updateNotification(notification: Notification) {

	fun importWatchHistory(context: Context,uris: List<Uri>, importFormat: ImportFormat) {
	fun startImportWatchHistoryWorker(context: Context,uris: List<Uri>, importFormat: ImportFormat) {

		if (videos.isEmpty()) {
		applicationContext.toastFromMainDispatcher(R.string.emptyList)

		private var importFormat: ImportFormat = ImportFormat.NEWPIPE


		override val titleResourceId: Int = R.string.backup_restore

Uh oh!

Conversation

SE-Bilal-Ahmad commented Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SE-Bilal-Ahmad commented Nov 29, 2025

Uh oh!

Bnyro left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SE-Bilal-Ahmad commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Bnyro commented Dec 12, 2025

Uh oh!

SE-Bilal-Ahmad commented Dec 12, 2025

Uh oh!

ULTRA-LEGENDS commented Jan 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bnyro Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SE-Bilal-Ahmad commented Nov 29, 2025 •

edited

Loading

Bnyro left a comment •

edited

Loading

SE-Bilal-Ahmad commented Dec 12, 2025 •

edited

Loading

Bnyro Feb 19, 2026 •

edited

Loading