build: optimize protobuf classes#7967
Merged
FineFindus merged 1 commit intolibre-tube:masterfrom Nov 28, 2025
Merged
Conversation
Instead of keeping all protobuf-generated classes (which disables R8's optimizations for that class), use the undocumented option which keeps, optimizes protobuf classes. Ref: libre-tube#7571 Ref: https://issuetracker.google.com/issues/144631039
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we keep all of NewPipeExtractors protobuf classes. This is overly broad as it disables all of R8's optimizations (e.g. it keeps unused fields and classes), however when not set, R8 removes all protobuf classes. R8 has an undocumented flag, which keeps and optimizes protobuf-generated classes. It also saves us from manually excluding all (new) protobuf classes.
While this currently has little impact, as all the generated protobuf classes are used, it will have a larger impact once #7689 is merged, which brings quite a few (unused) generated protobuf classes.
Ref: #7571
Ref: https://issuetracker.google.com/issues/144631039