Skip to content

Add publish to dockerhub github action#26

Merged
kapicic merged 13 commits intomainfrom
stevan/eng-494
Aug 5, 2025
Merged

Add publish to dockerhub github action#26
kapicic merged 13 commits intomainfrom
stevan/eng-494

Conversation

@kapicic
Copy link
Contributor

@kapicic kapicic commented Aug 1, 2025

📋 Pull Request Summary

🔗 Related Issues

  • Fixes #
  • Relates to #

📝 Changes Made

🧪 Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • All existing tests pass

Testing Details:

📚 Documentation

  • Code is self-documenting with clear variable/function names
  • Added/updated JSDoc comments for public APIs
  • Updated README.md if needed
  • Updated other documentation files
  • No documentation changes needed

🔄 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test improvements

🚨 Breaking Changes

  • This PR introduces breaking changes
  • Migration guide provided
  • Deprecation warnings added

Breaking Change Details:

📸 Screenshots/Videos

📋 Additional Notes

@kapicic kapicic self-assigned this Aug 1, 2025
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

.env.docker Outdated

# Provide the Netlify token to enable app deployment
NETLIFY_AUTH_TOKEN='example'
AUTH_SECRET='some44charactersstringsome44charactersstring'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put it above ENCRYPTION_KEY please.

.env.example Outdated

# Provide the Netlify token to enable app deployment
NETLIFY_AUTH_TOKEN=
AUTH_SECRET=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put it above ENCRYPTION_KEY please.

- main
pull_request:
branches:
- main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need some staging environment for the Docker images so we have more control over publishing.
If all the latest main code goes directly into a public image I'm a bit concerned there could be some mistakes.
Wdyt?

@kapicic kapicic merged commit 4af11b5 into main Aug 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants