Skip to content

Refactor telemetry environment variable handling#19

Merged
ATechAdventurer merged 3 commits intomainfrom
fix/telemetry-env-bug
Jul 31, 2025
Merged

Refactor telemetry environment variable handling#19
ATechAdventurer merged 3 commits intomainfrom
fix/telemetry-env-bug

Conversation

@ATechAdventurer
Copy link
Member

Update the handling of the NEXT_PUBLIC_DISABLE_TELEMETRY variable to accept string inputs and utilize JSON parsing for boolean conversion.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ATechAdventurer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of the NEXT_PUBLIC_DISABLE_TELEMETRY environment variable. The core objective is to make the environment variable parsing more resilient by enabling it to correctly interpret string inputs as boolean values, ensuring consistent behavior across different deployment environments.

Highlights

  • Telemetry Environment Variable Handling: The NEXT_PUBLIC_DISABLE_TELEMETRY environment variable's parsing logic has been updated to accept string inputs, allowing for more flexible configuration.
  • Improved Type Coercion: The previous direct boolean coercion (coerce: true) has been replaced with a preprocess step that explicitly uses JSON.parse to convert the incoming string value into a boolean, enhancing robustness.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ATechAdventurer ATechAdventurer requested a review from skosijer July 31, 2025 14:59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request refactors the environment variable handling for telemetry. I've found a critical issue in the new implementation that could cause the application to crash on startup if the NEXT_PUBLIC_DISABLE_TELEMETRY environment variable is not set. I've provided a suggestion to make the parsing more robust and prevent this crash.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ATechAdventurer ATechAdventurer merged commit f0ddf14 into main Jul 31, 2025
3 checks passed
@ATechAdventurer ATechAdventurer deleted the fix/telemetry-env-bug branch July 31, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants