Fix document MIME types and add FileName to DocumentMessage#199
Open
CaceresCallieri wants to merge 1 commit intolharries:mainfrom
Open
Fix document MIME types and add FileName to DocumentMessage#199CaceresCallieri wants to merge 1 commit intolharries:mainfrom
CaceresCallieri wants to merge 1 commit intolharries:mainfrom
Conversation
Documents (PDFs, Office files, etc.) were sent with application/octet-stream MIME type and no FileName field, causing them to appear as "Untitled" without preview in WhatsApp. Changes: - Add explicit MIME types for PDF, DOC/DOCX, XLS/XLSX, PPT/PPTX, CSV, TXT, ZIP with correct IANA-registered types (including OOXML types for modern Office formats) - Add FileName field to DocumentMessage so WhatsApp displays the actual filename instead of "Untitled" - Use filepath.Ext and filepath.Base instead of manual string slicing for safer path handling (fixes edge case when path has no extension)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/octet-streamMIME type and noFileNamefield, causing them to appear as "Untitled" without preview in WhatsApp.Changes
application/vnd.openxmlformats-officedocument.wordprocessingml.documentfor.docx)FileNamefield toDocumentMessageso WhatsApp displays the actual filename instead of "Untitled"strings.LastIndex) withfilepath.Extandfilepath.Basefor safer path handlingTest plan
send_file— confirms it now shows with title and preview in WhatsAppapplication/octet-stream