Conversation
as of this rust has to be bumped to 1.93.1 Signed-off-by: Christoph Ostarek <christoph@zededa.com>
|
Can we merge this independently of and before the Alpine 3.22 update? |
Perhaps it is better to merge it and bump it into lf-edge/eve repo after lf-edge/eve#5650 has been merged. @rucoder what do you think? |
|
Why "has to be"? We pin rust versions for consumers. This repo has its own CI , do we really want to merge all that in eve ? Besides if we bump rust version , who will update tui, installer and vector ? The way we install rust is independent from alpine rust package. Besides it is NOT recommended to use distro's package. Dostro have rust for installing rust based tools and usually do not provide a full package. Recommended way is to use rustup and this is what this package is doing |
Because if some other change is put into eve-rust one would have to wait until lf-edge/eve#5650 is merged, unless it does not matter if eve-rust uses a newer alpine version than the packages in EVE. |
eriknordmark
left a comment
There was a problem hiding this comment.
There is a moderate security issue for the time crate (but I doubt it is reachable in EVE) but it would be nice to be able to update that crate. But it requires a newer version of rustc (at least 1.88.0).
So I'm inclined to merge this and switch to resulting new eve-rust container.
Let's build this to start with.
as of this rust has to be bumped to 1.93.1