Conversation
|
|
||
| # needed for cargo-chef and cargo-sbom, as well as many other compilations | ||
| RUN apk add musl-dev linux-headers make clang mold python3 git | ||
| RUN apk add musl-dev linux-headers make clang mold python3 git perl protoc |
There was a problem hiding this comment.
should we maybe just include it in the builder container for vector? or could other rust-based EVE parts benefit from this components?
There was a problem hiding this comment.
@europaul this is what I do now but we must not call apk add in the container this is why I add it here.
There was a problem hiding this comment.
@europaul another way is to also use eve-alpine to get tools but i do not want to do it now. it would require PRs in eve which do not make sense for POC
There was a problem hiding this comment.
but I thought we can include them in the "build" stage of vector's dockerfile
There was a problem hiding this comment.
@europaul we shouldn't. The container will be built under LK and the build will not be reproducible. Alpine can have version of the tool updated between builds.
There was a problem hiding this comment.
but you fix the version of alpine some place and then the packages' versions are also fixed. or am I wrong?
- this is done to build vector for EVE which pins version 1.85 - also add perl and protoc required by vector build - bump up cargo-chef version Signed-off-by: Mikhail Malyshev <mike.malyshev@gmail.com>
rucoder
force-pushed
the
rucoder/1.85.1-upgrade
branch
from
fa60978 to
4fdabff
Compare
3 participants
IMPORTANT: Allow 4th component in tag names after '-' #15 should be merged first
this is done to build vector for EVE which pins version 1.85
also add perl and protoc required by vector build
bump up cargo-chef version