Add SCEP ChallengePassword to EncryptionBlock#137
Merged
rene merged 2 commits intolf-edge:mainfrom Feb 16, 2026
Merged
Conversation
Commit 35ae108 added support for certificate enrollment using the SCEP protocol. SCEP profiles can optionally include a ChallengePassword for one-time or shared-secret authorization during certificate enrollment. Since this is a sensitive value, it must be encrypted inside the CipherBlock. This commit fixes an oversight: the ChallengePassword was not included in EncryptionBlock (the proto message encrypted in CipherBlock.CipherData). Signed-off-by: Milan Lenco <milan@zededa.com>
No functional changes; generated code and assets only. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
scep-challenge-password
branch
from
0a5aecd to
cddf7d1
Compare
Contributor
Author
|
@uncleDecart Could you please approve this small PR? I need to merge this to move forward with EVE and cloud implementation. |
uncleDecart
approved these changes
Feb 16, 2026
Member
|
@milan-zededa , apologies, slipped through my fingers, although I don't think my approve would give you ability to merge it 😢 |
Contributor
Author
True, even with our powers combined we are still not strong enough to press that merge button :(( |
Member
We need superpowers, @eriknordmark, could you help us? |
rene
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 35ae108 added support for certificate enrollment using the SCEP protocol.
SCEP profiles can optionally include a
ChallengePasswordfor one-timeor shared-secret authorization during certificate enrollment.
Since this is a sensitive value, it must be encrypted inside the
CipherBlock.This commit fixes an oversight: the
ChallengePasswordwas not included inEncryptionBlock(the proto message encrypted inCipherBlock.CipherData).