Use unique DB name for Postgres test fixture#163
Open
leynos wants to merge 1 commit into
Open
Conversation
Contributor
Reviewer's GuideRevised the Postgres test fixture to generate timestamp-based unique database names per invocation, updated mermaid validation instructions for clarity, and documented the per-test DB naming behavior in the Rust testing guide. Class diagram for PostgresTestDb fixture changesclassDiagram
class PostgresTestDb {
+new() PostgresTestDb
+db_name: String
+connect() Connection
}
note for PostgresTestDb "Now generates a unique db_name per test invocation"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Warning Rate limit exceeded@leynos has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 37 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate Unit Tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gates Passed
See analysis details in CodeScene
Quality Gate Profile: Pay Down Tech Debt
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @leynos - I've reviewed your changes - here's some feedback:
- Consider using a UUID or random suffix for the DB name to guarantee uniqueness rather than relying on the system clock, which might collide under high concurrency.
- Ensure the test fixture cleans up/drops the created databases after each test run to avoid accumulating orphaned databases.
- Include the generated database name in the error messages or logs to aid debugging when the fixture fails to start or create the DB.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using a UUID or random suffix for the DB name to guarantee uniqueness rather than relying on the system clock, which might collide under high concurrency.
- Ensure the test fixture cleans up/drops the created databases after each test run to avoid accumulating orphaned databases.
- Include the generated database name in the error messages or logs to aid debugging when the fixture fails to start or create the DB.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo clippy -- -D warningsRUSTFLAGS="-D warnings" cargo testcargo clippy --no-default-features --features postgres -- -D warnings(fails: could not compilepostgres-setup-unpriv)RUSTFLAGS="-D warnings" cargo test --no-default-features --features postgres(fails: could not compilepostgres-setup-unpriv)markdownlint '**/*.md'nixie **/*.mdhttps://chatgpt.com/codex/tasks/task_e_685299d37b00832283b9fa013c62b53a
Summary by Sourcery
Generate timestamp-based unique database names for Postgres test fixtures, enable parallel-safe testing, and update related documentation and mermaid validation instructions.
New Features:
Enhancements:
Documentation: