Fix UTF-8 encoding bug for 4-byte Unicode characters#34
Open
lewisbobrow wants to merge 1 commit intolevyfan:masterfrom
Open
Fix UTF-8 encoding bug for 4-byte Unicode characters#34lewisbobrow wants to merge 1 commit intolevyfan:masterfrom
lewisbobrow wants to merge 1 commit intolevyfan:masterfrom
Conversation
lewisbobrow
force-pushed
the
fix-utf8-encoding
branch
from
938c74d to
db49073
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33
The code used
GetStringUTFChars/NewStringUTFwhich converts Java Strings to "Modified UTF-8". In Modified UTF-8, 4-byte Unicode characters (Mathematical Bold, emoji, etc.) are incorrectly encoded, causing SentencePiece to return UNK tokens.GetStringUTFCharswith Java'sString.getBytes("UTF-8")for proper UTF-8 encoding