fix(less): upgrade make-dir to v4 to fix security vulnerability#4426
fix(less): upgrade make-dir to v4 to fix security vulnerability#4426jorenbroekema wants to merge 1 commit intoless:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can enforce grammar and style rules using `languagetool`.Configure the |
What:
Bump make-dir to v5
Why:
There is a security vulnerability in make-dir v2:
Which is fixed by upgrading make-dir to latest
Checklist:
Additional context:
The main changes in make-dir is that it is now ESM-only and minimum Node 18 requirement. Less also has the same Node version requirement, so no issue there.
This is only used in less bin file, and we use
createRequireto allow importing ESM dependencies, so also no issues there.From Node 20.x latest and 22.x latest, we'd be able to require() them without needing the helper, which is faster, but not really something to go out of your way to change if you ask me in this context.
See also the PR from 2+ years ago that was closed for being stale. #4250
I hope this one will make it through :)
Summary by CodeRabbit