feat(controls): MessageBox button focus and window positioning#1613
Open
Koichi-Kobayashi wants to merge 2 commits intolepoco:mainfrom
Open
feat(controls): MessageBox button focus and window positioning#1613Koichi-Kobayashi wants to merge 2 commits intolepoco:mainfrom
Koichi-Kobayashi wants to merge 2 commits intolepoco:mainfrom
Conversation
- Add checkIsFocused parameter to SetFocusToFirstAvailableButton method to control focus validation based on timing - Call SetFocusToFirstAvailableButton with checkIsFocused: false in OnLoaded and OnApplyTemplate to attempt early focus setting - Call SetFocusToFirstAvailableButton with checkIsFocused: true in OnContentRendered to respect developer's focus logic - Skip focus setting if focus is already on any button - Skip focus setting if focus is on a non-button control (e.g., TextBox) - Set focus to primaryButton when focus is on MessageBox itself or nowhere - Add Gallery sample demonstrating auto-focus behavior when no button or non-button control has focus
github-actions
bot
added
controls
pomianowski
added
help_wanted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The buttons were not receiving focus, and pressing the spacebar or Enter key did not produce any response.
Issue Number: N/A
What is the new behavior?
Other information
Default focus settings are now available.
