fix(controls): Remove duplicate right‑click event handling in TitleBar #1612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
controls
pomianowski
changed the title
apachezy
force-pushed
the
fix/titlebar-MouseRightButtonUp
branch
from
bbf01cc to
4ed7c8d
Compare
apachezy
force-pushed
the
fix/titlebar-MouseRightButtonUp
branch
from
4ed7c8d to
b0dcb58
Compare
Nuklon
approved these changes
Jan 6, 2026
Collaborator
Nuklon
left a comment
Nuklon
left a comment
There was a problem hiding this comment.
Can confirm this works OK.
Contributor
Author
|
The TitleBar has accumulated significant technical debt: excessive properties, workarounds that bypass WPF best practices, poor UX, and complex maintenance. A full refactor is needed for long-term viability. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The current TitleBar already handles right‑click system menus via
HwndSourceHook. However, theMouseRightButtonUpevent is also subscribed and unconditionally pops up the system menu, resulting in:Duplicate system‑menu handling in TitleBar; a system menu always appears on right‑click.
Right‑click menus of controls inside
TrailingContentcannot be shown.Issue Number: N/A
What is the new behavior?
The handler for the
MouseRightButtonUpevent has been temporarily commented out (code is preserved). It can be restored later if a WPF‑based system‑menu implementation is needed in the future.After the change, both the system menu and control‑specific context menus now work correctly:
Other information