feat(controls) Added new icon element (and markup) - DrawingBrushIcon. New constants for NavigationLeftCompact#1061
Open
MarekJur wants to merge 12 commits intolepoco:mainfrom
Open
feat(controls) Added new icon element (and markup) - DrawingBrushIcon. New constants for NavigationLeftCompact#1061MarekJur wants to merge 12 commits intolepoco:mainfrom
DrawingBrushIcon. New constants for NavigationLeftCompact#1061MarekJur wants to merge 12 commits intolepoco:mainfrom
Conversation
github-actions
bot
added
controls
pomianowski
requested changes
Apr 20, 2024
src/Wpf.Ui.Gallery/App.xaml
Outdated
| <helpers:PaneDisplayModeToIndexConverter x:Key="PaneDisplayModeToIndexConverter" /> | ||
|
|
||
|
|
||
|
|
|
|
||
| using System.Windows.Controls; | ||
|
|
||
| namespace Wpf.Ui.Controls; |
Member
There was a problem hiding this comment.
Suggested change
| namespace Wpf.Ui.Controls; | |
| namespace Wpf.Ui.Controls; | |
| // If a copy of the MIT was not distributed with this file, You can obtain one at https://opensource.org/licenses/MIT. | ||
| // Copyright (C) Leszek Pomianowski and WPF UI Contributors. | ||
| // All Rights Reserved. | ||
|
|
| using System.Windows.Controls; | ||
|
|
||
| namespace Wpf.Ui.Controls; | ||
| public class DrawingBrushIcon : IconElement |
Member
There was a problem hiding this comment.
Missing docs for the public API
| { | ||
| var self = (DrawingBrushIcon)d; | ||
| if (self.Border is null) | ||
| return; |
Member
There was a problem hiding this comment.
Missing brackets according to the .editorconfig
| xmlns:converters="clr-namespace:Wpf.Ui.Converters" | ||
| xmlns:system="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <!--#region navigation leftConstants --> |
| xmlns:system="clr-namespace:System;assembly=mscorlib"> | ||
|
|
||
| <!--#region navigation leftConstants --> | ||
| <!--<system:Double x:Key="PaneToggleButtonHeight">40</system:Double> |
| [ContentProperty(nameof(Icon))] | ||
| [MarkupExtensionReturnType(typeof(DrawingBrushIcon))] | ||
| public class DrawingBrushIconExtension : MarkupExtension | ||
| { |
pomianowski
changed the title
DrawingBrushIcon. New constants for NavigationLeftCompact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Drawing brush cant be use for icon element.
For change left navigation menu size must override all style.
What is the new behavior?
DrawingBrush can be used like icon element (example in Gallery).
Easy way to change width for navigation menu (constants)
Other information