This repository was archived by the owner on Aug 17, 2026. It is now read-only.
fix(dev-portal): restore stroke=currentColor on sidebar icons (closes #48) - #54
Merged
Merged
Conversation
After the shadcn migration in PR #41, the sidebar icons rendered invisibly because `admin-layout.css` (which carried `.admin-nav__icon svg path { stroke: currentColor; }`) was deleted — leaving the inline SVGs with `fill="none"` but no stroke directive. Add the four Lucide-style stroke attributes to the shared `COMMON` props on `icons.tsx` so every `<path>/<line>/<circle>` paints with the inherited `currentColor`. The wrapper `text-…` utilities on `AdminShell` already supply that colour, including the active-state accent — no callsite changes needed. Pin the regression in `tests/stories/dev-portal-pages.story.test.ts` so a future agent can't silently drop the stroke attributes again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pascal-klesse
force-pushed
the
fix-issue-048-sidebar-icons
branch
from
May 2, 2026 21:04
1b407e9 to
20ef4ad
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<svg>was rendered withfill="none"but no stroke, so the<path>/<line>/<circle>elements painted nothing.COMMONprops insrc/core/dx/clients/layout/icons.tsx:stroke="currentColor",strokeWidth={1.75},strokeLinecap="round",strokeLinejoin="round". The wrappertext-…utilities onAdminShellalready supply the colour, including the active-state accent (text-accent).tests/stories/dev-portal-pages.story.test.tsso a future refactor can't silently drop the stroke attributes again.Why this works
The legacy CSS rule that compensated for the missing stroke (
.admin-nav__icon svg path { stroke: currentColor; }in the deletedadmin-layout.css) is gone. Adding the stroke attributes directly on the SVG closes the gap and keeps icon colour inheritance flowing throughcurrentColor— exactly whattext-accenton the active<NavLink>already drives.BRAND_LOGOalready declared its strokes inline and was unaffected.Acceptance criteria (Issue #48)
COMMONprops extended withstroke="currentColor"+strokeWidth={1.75}+strokeLinecap="round"+strokeLinejoin="round"tests/stories/dev-portal-pages.story.test.tsasserts the four stroke attributes are presentcurrentColorinheritance — no callsite changes neededTest plan
bun run lint— cleanbun run format— cleanbun run test:types— cleanbun run test:unit— 153/153 passedbun run test:e2e— 2412/2412 passed (story-test pin transitioned RED → GREEN)bun run test:coverage— 91.09% statements / 81.88% branches / 92.96% lines, thresholds metbun run build:dev-portal— 57 artifacts (971.7 kB)bun run build— full server build cleanbun run dev(human reviewer): every sidebar section icon visible, active-state lime tint correctOut of scope
lucide-react(breaking — icon names + paths change)🤖 Generated with Claude Code