Use useGoBack for course back navigation instead of hardcoded HOME by nucleogenesis · Pull Request #14403 · learningequality/kolibri

nucleogenesis · 2026-03-18T18:15:58Z

Summary

CourseWelcomePage hardcoded its back arrow to always navigate to the Home page,
regardless of where the user came from. This fix adopts the existing
useGoBack / usePreviousRoute pattern (used in Facility and Coach plugins)
for course navigation:

New CourseRootPage wrapper component calls usePreviousRoute() and renders <router-view />
Course routes are nested as children of CourseRootPage, enabling previous route tracking
CourseWelcomePage uses useGoBack({ fallbackRoute: HOME }) instead of a hardcoded HOME link

This follows the same pattern as UsersRootPage (Facility), QuizResourceSelection and
LessonResourceSelection (Coach).

References

Fixes #14222

Review guidance

QA guidance

I took these steps to confirm the fix

Setup prerequisites:

A facility with at least one class
A learner enrolled in that class
At least one course assigned to that class
Content channels imported so the course has content

Test path 1: From Classes page

Sign in as a learner with assigned courses
Navigate to Classes > [Your Class]
Click a course card
On the CourseWelcomePage, click the back arrow
Expected: returns to the class page, not Home

Test path 2: From Home page

Sign in as the same learner
From the Home page, click a course card
On the CourseWelcomePage, click the back arrow
Expected: returns to Home

Test path 3: Regression tests on 'no classes guard'

This is to ensure that we still correctly redirect people who are not in the class given in their URL

'Signin' as a user by way of the "Explore without account" in an incognito window
Copy the URL to a course or class page from a regular browser and try to access it as the anonymous user in incognito
See that the user is simply redirected to the Library (this is expected as they are not in any class)

Note that the other case I tested was for a logged-in user trying to go to a class URL for a class they're not in and it resulted in a 404 Error which is right because to the user not in the class, the class doesn't exist.

Code Reviewer notes (from Claude)

CourseRootPage is a thin wrapper (~15 lines) following an established pattern — compare with
UsersRootPage in Facility or QuizResourceSelection in Coach
Course routes were restructured from flat to nested under CourseRootPage, with the
noClassesGuard handler consolidated on the parent route. URL paths are unchanged.
We initially explored the useContentLink query-param approach (used by TopicsPage for deep
content browsing), but useGoBack is a better fit here — CourseWelcomePage is simple
"go back one level" navigation, not deep content browsing
The useGoBack pattern relies on onBeforeRouteUpdate firing on CourseRootPage when
CourseUnitView does router.replace to CourseWelcomePage (both are child routes).
This sets previousRoute, enabling router.back() to return to the correct origin page.
When no previous route exists (direct link/refresh), it falls back to HOME.

AI usage

I used Claude Code to investigate the root cause, trace the navigation chain, and explore
two approaches: query-param threading via useContentLink and the useGoBack /
usePreviousRoute pattern. After testing both, we chose useGoBack as the better fit
for this use case. I reviewed the generated code and verified it follows the same pattern
used elsewhere in the codebase.

CourseWelcomePage hardcoded its back arrow to always navigate to HOME, ignoring where the user came from. Fix by: - Adding CourseRootPage as a route-level wrapper that calls usePreviousRoute(), providing previous route tracking for all course child routes - Nesting course routes as children of CourseRootPage - Replacing the hardcoded homePageLink in CourseWelcomePage with useGoBack(), falling back to HOME when no previous route exists This follows the same pattern used in Facility (UsersRootPage) and Coach (QuizResourceSelection, LessonResourceSelection) plugins. Fixes learningequality#14222 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The Kolibri router's handler system only extracts handlers from top-level routes, not children. Since course routes are now nested under CourseRootPage, the noClassesGuard handler was not firing. Switch to Vue Router's native beforeEnter guard on the parent route, which fires for all child route navigations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rtibblesbot

Clean bugfix that correctly adopts the established usePreviousRoute/useGoBack pattern for course back navigation.

CI: Python tests passing. Frontend tests, linting, and WHL build still pending — verify before merge.

suggestion (1): Bare /course path is now routable — see inline comment on classesRoutes.js:90
praise (2): See inline comments

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Reviewed the pull request diff checking for:

Correctness: bugs, edge cases, undocumented behavior, resource leaks, hardcoded values
Design: unnecessary complexity, naming, readability, comment accuracy, redundant state
Architecture: duplicated concerns, minimal interfaces, composition over inheritance
Testing: behavior-based assertions, mocks only at hard boundaries, accurate coverage
Completeness: missing dependencies, unupdated usages, i18n, accessibility, security
Principles: DRY (same reason to change), SRP, Rule of Three (no premature abstraction)
Checked CI status and linked issue acceptance criteria
For UI changes: inspected screenshots for layout, visual completeness, and consistency

rtibblesbot · 2026-03-18T18:19:34Z

kolibri/plugins/learn/frontend/routes/classesRoutes.js

-    name: PageNames.COURSE_WELCOME,
-    path: '/course/:courseSessionId([a-f0-9]{32})/welcome',
-    component: CourseWelcomePage,
+    path: '/course',


suggestion: The parent route path: '/course' is now a routable URL, but it has no name, no redirect, and no default child. If a user navigates to /course directly, they'll see CourseRootPage rendering an empty <router-view /> — a blank page.

No UI link currently points to bare /course, so this is unlikely to be hit in practice. But a defensive redirect (e.g., to HOME) would prevent the blank page if someone bookmarks or manually enters the URL. Low priority — just something to be aware of.

rtibblesbot · 2026-03-18T18:19:34Z

kolibri/plugins/learn/frontend/views/CourseRootPage.vue

+
+  export default {
+    name: 'CourseRootPage',
+    setup() {


praise: Minimal wrapper following the exact same pattern as UsersRootPage in Facility — just usePreviousRoute() + <router-view />. Good restraint keeping it thin.

rtibblesbot · 2026-03-18T18:19:34Z

kolibri/plugins/learn/frontend/views/CourseWelcomePage.vue

    :appBarBgColor="$themeTokens.surface"
    :appBarHoverBgColor="$themePalette.grey.v_100"
    :appearanceOverrides="{ backgroundColor: $themeTokens.surface }"
+    @navIconClick="goBack"


praise: Good switch from :route to @navIconClick. ImmersiveToolbar renders a static <router-link> when route is provided, but useGoBack needs runtime logic to choose between router.back() and the fallback — so the event handler is the correct mechanism.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rtibblesbot

Clean follow-up addressing the prior suggestion.

Delta from prior review

RESOLVED: bare /course blank page — redirect: '/' added (d5be2cb)
New: beforeEnter consolidation moves the noClassesGuard to the parent route, eliminating six identical handler wrappers. Good simplification.

CI: build assets still in progress — verify before merge.

No new findings.

@rtibblesbot's comments are generated by an LLM, and should be evaluated accordingly

How was this generated?

Compared the current PR state against findings from a prior review:

Retrieved prior bot reviews deterministically via the GitHub API
Classified each prior finding as RESOLVED, UNADDRESSED, ACKNOWLEDGED, or CONTESTED
Only raised NEW findings for newly introduced code
Reviewed the pull request diff checking for correctness, design, architecture, testing, completeness, and adherence to DRY/SRP principles
Checked CI status and linked issue acceptance criteria

rtibblesbot · 2026-03-18T18:42:39Z

kolibri/plugins/learn/frontend/routes/classesRoutes.js

+        return;
      }
+      next();
    },


praise: Clean consolidation — six identical handler wrappers replaced with a single beforeEnter on the parent. The guard only needs to check class membership on entry to the /course subtree, not on every sibling navigation, so this is both simpler and semantically correct.

github-actions · 2026-03-18T18:53:40Z

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.19.3.dev0_git.20260318182535.pex
Windows Installer (EXE)	kolibri-0.19.3.dev0+git.20260318182535-windows-setup-unsigned.exe
Debian Package	kolibri_0.19.3.dev0+git.20260318182535-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.19.3.dev0+git.20260318182535.dmg
Android Package (APK)	kolibri-0.19.3.dev0+git.20260318182535-0.1.7-debug.apk
Raspberry Pi Image	kolibri-pi-image-0.19.3.dev0+git.20260318182535.zip
TAR file	kolibri-0.19.3.dev0+git.20260318182535.tar.gz
WHL file	kolibri-0.19.3.dev0+git.20260318182535-py2.py3-none-any.whl

Smoke test screenshot

Download screenshot

nucleogenesis and others added 2 commits March 18, 2026 10:45

nucleogenesis requested a review from rtibblesbot March 18, 2026 18:16

github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: medium labels Mar 18, 2026

rtibblesbot reviewed Mar 18, 2026

View reviewed changes

Add redirect on bare /course path to prevent blank page

d5be2cb

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

rtibblesbot approved these changes Mar 18, 2026

View reviewed changes

nucleogenesis linked an issue Mar 18, 2026 that may be closed by this pull request

Courses - Clicking the back arrow always brings the user back to the 'Home' page #14222

Open

rtibbles self-assigned this Mar 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use useGoBack for course back navigation instead of hardcoded HOME#14403

Use useGoBack for course back navigation instead of hardcoded HOME#14403
nucleogenesis wants to merge 3 commits intolearningequality:release-v0.19.xfrom
nucleogenesis:14222--bugfix--back-arrow-dont-go-home

nucleogenesis commented Mar 18, 2026

Uh oh!

rtibblesbot left a comment

Uh oh!

rtibblesbot Mar 18, 2026

Uh oh!

rtibblesbot Mar 18, 2026

Uh oh!

rtibblesbot Mar 18, 2026

Uh oh!

rtibblesbot left a comment

Uh oh!

rtibblesbot Mar 18, 2026

Uh oh!

github-actions bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nucleogenesis commented Mar 18, 2026

Summary

References

Review guidance

QA guidance

Code Reviewer notes (from Claude)

AI usage

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Uh oh!

rtibblesbot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

rtibblesbot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

rtibblesbot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

rtibblesbot left a comment

Choose a reason for hiding this comment

Delta from prior review

Uh oh!

rtibblesbot Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Artifacts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Mar 18, 2026 •

edited

Loading