Warn when --plugins and --file are both given to kolibri-build prod#14102
Draft
nucleogenesis wants to merge 1 commit intolearningequality:release-v0.19.xfrom
Draft
Warn when --plugins and --file are both given to kolibri-build prod#14102nucleogenesis wants to merge 1 commit intolearningequality:release-v0.19.xfrom
kolibri-build prod#14102nucleogenesis wants to merge 1 commit intolearningequality:release-v0.19.xfrom
Conversation
they're mutually exclusive, --plugins will be ignored. This also introduces a build-base script to package.json which can be used to run the base build with no flags at all
Contributor
Build Artifacts
|
nucleogenesis
modified the milestones:
Kolibri 0.19: Planned Patch 2,
Kolibri 0.19: Planned Patch 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
they're mutually exclusive, --plugins will be ignored. This also introduces a build-base script to package.json which can be used to run the base build with no flags at all
Summary
build-basescript to package.json that only calls the prod command w/ --transpilebuild- then passes the default file.References
I ran into this trying to do
pnpm run build --plugins kolibri.plugins.coachand didn't realize until @rtibbles noticed that it was because the--file ...arg is hard-coded into the package.json script forbuild.Reviewer guidance
I just kind of did what I wanted here so this is a non-urgent request for feedback.
Does this API make sense - should we avoid the package.json script or approach it another way?
What about the error message w/ regard to the updated command.
Would we run into similar problems by hard-coding
--transpileinto thebuild-base?