fix: correct lean_kernel_diag_is_enabled declaration to match generated C - #14886
Open
FawadHa1der wants to merge 1 commit into
Open
fix: correct lean_kernel_diag_is_enabled declaration to match generated C#14886FawadHa1der wants to merge 1 commit into
FawadHa1der wants to merge 1 commit into
Conversation
Contributor
Author
|
maintainers apply the appropriate labels please. may be changelog-no (no observable change on supported targets) since wasm64 is not supported at the moment. |
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the lean_kernel_diag_is_enabled C++ declaration to match generated C. This issue is manifesting only for wasm64 output but it is an issue nonetheless. C++ compiled to wasm64 via emscripten incorrectly translates based on the C++ external declaration.
Closes issue 14865