Fix #148 Add Redis::CommandError handling - #160
Conversation
|
@jakephot - since this is essentially your solution re-wrapped, I wonder if you have any comments |
|
that's amazing @corsonknowles thank you! can you add the |
5eccb15 to
08800d7
Compare
I pushed that up and then found So switched to address it that way. |
|
@corsonknowles Looks great! I'm excited to upgrade to |
|
I like the reborn but prefer rebirth 😆 just kidding, it seems we are still pointing to coveralls |
… coveralls dependency that was still pulling ostruct
|
I think it's still called that, but I had failed to update the json version, so it was still requiring ostruct transitively from the older version. Updated |
|
I think we'll drop support to 2.5 and 2.6 which should be fine, they are EOL anyways. |
|
thank you so much @corsonknowles |

Redlock 2.0+ mostly supports object instantiation, except for this edge case.
See:
Aside from causing difficulties while upgrading, this limits the use of certain functionality.
I tried to be careful in error handling here that the error class is defined and loaded. This is an extension of the solution offered here:
Added a spec context for good measure.