fix: wrap stream errors in valid OpenAI chunks#2376
Open
Stranmor wants to merge 1 commit intolbjlaq:mainfrom
Open
fix: wrap stream errors in valid OpenAI chunks#2376Stranmor wants to merge 1 commit intolbjlaq:mainfrom
Stranmor wants to merge 1 commit intolbjlaq:mainfrom
Conversation
All SSE stream error responses now use structurally valid formats that IDE parsers (Cursor, etc.) can process without crashing: - OpenAI modern stream: choices[0].delta.content with error text - OpenAI legacy stream: same choices[0].delta.content pattern - Gemini handler: valid candidates[].content.parts[].text format so downstream OpenAI mappers translate it correctly Fixes lbjlaq#2371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2371. Prevents IDE parsers (Cursor, etc.) from crashing on custom error JSON objects by wrapping all SSE stream errors in structurally valid formats.
Changes
Problem: PR #2322 changed
yield Err(...)toyield Ok(Bytes::from(json!({"error":...}))). This custom JSON shape crashes IDE parsers that strictly expectchoices[0].deltain every SSE chunk.Fix: All stream error responses now use valid formats:
{"error":{...}, "choices":[]}{"choices":[{"delta":{"content":"[Antigravity Error: ...]"}, "finish_reason":"stop"}]}{"error":{...}}{"candidates":[{"content":{"parts":[{"text":"[Error]"}]}}]}— valid Gemini format that downstream OpenAI mappers translate correctlyThe error message is rendered as normal assistant text in the IDE chat, making it visible to the user without crashing the parser.