fix: exclude trailing quotes from URLs in error dialog#2273
Open
thebtf wants to merge 1 commit intolbjlaq:mainfrom
Open
fix: exclude trailing quotes from URLs in error dialog#2273thebtf wants to merge 1 commit intolbjlaq:mainfrom
thebtf wants to merge 1 commit intolbjlaq:mainfrom
Conversation
The renderMessageWithLinks regex /(https?:\/\/[^\s]+)/g was capturing trailing ", ', }, ], > characters from JSON-embedded URLs (e.g. Google API appeal_url wrapped in JSON quotes), producing invalid links like https://support.google.com/...?hl=en" Changed to /(https?:\/\/[^\s"'}\]>]+)/g to stop at these delimiters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderMessageWithLinksthat captured trailing",',},],>from JSON-embedded URLs"appeal_url":"https://..."), and the old regex/(https?:\/\/[^\s]+)/gwould include the trailing quote, producing invalid linksChanges
AccountErrorDialog.tsx: Changed regex to/(https?:\/\/[^\s"'}\]>]+)/gTest plan
"